You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ok. After brief testing I've found that recall runes do not work as they should.
First thing is bug in circle5/mark.src spell script.
if (cast_on.IsRecallRune())
SendSysMessage(caster, "You can only cast that on a recall rune!", color := 33);
return;
endif
it should be like this (exclamation mark is missing :) ):
if (!cast_on.IsRecallRune())
SendSysMessage(caster, "You can only cast that on a recall rune!", color := 33);
return;
endif
After fixing that I've found that items/rune/recallRune/use.src is checking 'x' prop instead of new Destination struct to see if rune is marked. Rune is marked but if we double click rune it will say it is not.
That probably needs switching to rune.GetDestination() method. But... if you do that we need some kind of error returned from that method because if you double click rune and use GetDestination() method then var destination := GetObjProperty( rune, "Destination" ); will return error which will lead to code that checks "old type rune" and that will fail also setting new Destination prop on blank rune with errors :)
So to fix that we need better checking if rune is old :) or maybe add IsRuneBlank() method :)
So far I've found this. I'm not sure where else this can go wrong too :) So because it's not just one exlamation mark I'll leave this here for review.
The text was updated successfully, but these errors were encountered:
Ok. After brief testing I've found that recall runes do not work as they should.
First thing is bug in circle5/mark.src spell script.
it should be like this (exclamation mark is missing :) ):
After fixing that I've found that items/rune/recallRune/use.src is checking 'x' prop instead of new Destination struct to see if rune is marked. Rune is marked but if we double click rune it will say it is not.
That probably needs switching to rune.GetDestination() method. But... if you do that we need some kind of error returned from that method because if you double click rune and use GetDestination() method then var destination := GetObjProperty( rune, "Destination" ); will return error which will lead to code that checks "old type rune" and that will fail also setting new Destination prop on blank rune with errors :)
So to fix that we need better checking if rune is old :) or maybe add IsRuneBlank() method :)
So far I've found this. I'm not sure where else this can go wrong too :) So because it's not just one exlamation mark I'll leave this here for review.
The text was updated successfully, but these errors were encountered: