Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with recall runes #31

Closed
AsYlum- opened this issue Jul 28, 2020 · 0 comments
Closed

Bug with recall runes #31

AsYlum- opened this issue Jul 28, 2020 · 0 comments
Labels

Comments

@AsYlum-
Copy link
Contributor

AsYlum- commented Jul 28, 2020

Ok. After brief testing I've found that recall runes do not work as they should.

First thing is bug in circle5/mark.src spell script.

if (cast_on.IsRecallRune())
        SendSysMessage(caster, "You can only cast that on a recall rune!", color := 33);
        return;
endif

it should be like this (exclamation mark is missing :) ):

if (!cast_on.IsRecallRune())
        SendSysMessage(caster, "You can only cast that on a recall rune!", color := 33);
        return;
endif

After fixing that I've found that items/rune/recallRune/use.src is checking 'x' prop instead of new Destination struct to see if rune is marked. Rune is marked but if we double click rune it will say it is not.

That probably needs switching to rune.GetDestination() method. But... if you do that we need some kind of error returned from that method because if you double click rune and use GetDestination() method then var destination := GetObjProperty( rune, "Destination" ); will return error which will lead to code that checks "old type rune" and that will fail also setting new Destination prop on blank rune with errors :)

So to fix that we need better checking if rune is old :) or maybe add IsRuneBlank() method :)

So far I've found this. I'm not sure where else this can go wrong too :) So because it's not just one exlamation mark I'll leave this here for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants