Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unreachable code after return statement #73

Closed
userquin opened this issue Nov 11, 2016 · 3 comments · Fixed by #74
Closed

unreachable code after return statement #73

userquin opened this issue Nov 11, 2016 · 3 comments · Fixed by #74

Comments

@userquin
Copy link

app-storage-behavior.html, line 470:

__pathRefersToArray: function(path) {
        return (SPLICES_RX.test(path) || LENGTH_RX.test(path))
            Array.isArray(this.get(this.__parentPath(path)));
},

Missing && expression in return statement:

__pathRefersToArray: function(path) {
        return (SPLICES_RX.test(path) || LENGTH_RX.test(path)) &&
            Array.isArray(this.get(this.__parentPath(path)));
},
@motss
Copy link
Contributor

motss commented Nov 15, 2016

@userquin @cdata Please take a look at this issue.

@motss
Copy link
Contributor

motss commented Nov 15, 2016

This throws error on FF but not Chrome.

@userquin
Copy link
Author

yes, only on FF but I don't know why Chrome works and if it is applying correctly the stament ;)

e111077 pushed a commit that referenced this issue Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants