-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
form.reset() does not completely reset some paper form elements #27
Comments
Im also facing this issue!. Its interesting to note that its been 3 months since this issue was posted. Still no response :-( |
I'm sorry, I haven't gotten around to looking at it. There were a billion other higher priority issues that got in the way. I'll try to take a look this week |
Thanks @notwaldorf - much appreciated! You guys are doing an amazing amount of stuff for such a small team. |
@hawkett Thanks for the kind words. They're very appreciated 💖 |
@notwaldorf Thanks a lot for this fix! Trying to reset a form using paper-input and this works great when all the element values have changed but it is not triggering the notify to the parent when el.value === this._customElementsInitialValues[i]. Doing some local testing seems like something like what I have below (not optimized, just nulling out as a proof of concept) does the trick:
Is opening a new issue best way to address this? Can also submit a pull request. |
I am experiencing this issue while attempting to reset a gold-email-input that is enclosed within an iron-form. It appears to be running one last auto-validation after the form is reset, causing it to turn red as if there was an error. Is .reset() supposed to clear auto-validation states as well? |
Re-opening, since |
I noticed that after form reset, the paper-radio buttons and paper-dropdown-menu breaks...the new form does not display default selections for these elements. Using "1.1.4" version. |
I'm seeing this issue in Polymer 2 with |
I have the same issue in Polymer 2, it reset correctly paper-input elements with name parameter set. Then, I have other named elements like paper-dropdown-menu containing a paper-listbox which is not reseted |
Example below shows the paper-input label continues to behave as though it has content.
Do form elements need additional notification on reset(), or do they need to handle the existing behaviour differently?
The text was updated successfully, but these errors were encountered: