New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0 CallerFactory public methods should be guarded by onlyAdmin #41

Closed

devfans opened this issue May 13, 2022 · 1 comment

devfans commented May 13, 2022

eth-contracts/contracts/core/cross_chain_manager/caller/CallerFactoryWithAdmin.sol

Line 23 in feb2956

function setAdmin(address newAdmin) public {

Looks missing onlyAdmin guard for setAdmin and setChildren method of CallFactory contract in 2.0.

devfans mentioned this issue

Add onlyAdmin guard for public methods #42

Closed

Author

devfans commented Feb 1, 2023

Close since fixed

devfans closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment