Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the most serious performance problem? #17

Closed
toyoaki-k opened this issue Mar 10, 2019 · 4 comments
Closed

What is the most serious performance problem? #17

toyoaki-k opened this issue Mar 10, 2019 · 4 comments

Comments

@toyoaki-k
Copy link

toyoaki-k commented Mar 10, 2019

In RFC 55, this http server seems to have perfomance problem as a http server

It still has poor performance characteristics

What is the most serious performance problem?
I think this sever creates one actor per one connection. I think that way is good for perfomance in terms of concurrent process of connections.

@SeanTAllen
Copy link
Member

The HTTP parser does a bunch of things that you shouldn't do if you care about performance. A large number of which are in the Pony Performance Cheatsheet as "don't do's".

That's where you would want to start.

The existing parser uses error has control flow. Definitely not good for performance.

@mfelsche
Copy link
Contributor

It also uses buffered.Reader to parse http payloads spanning > 1 tcp packet. In this process it copies all the bytes of the payload. I already have a few ideas on how to tackle those problems.

@toyoaki-k
Copy link
Author

@SeanTAllen
Thank you for teaching me the Pony Performance Cheatsheet! I will start reading it!

@mfelsche
Thank you for teaching me one cause of performance problems! I also want to think about it.

@SeanTAllen
Copy link
Member

you're welcome @toyoaki-k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants