Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for String.trim on already-trimmed strings. #2340

Closed
jemc opened this issue Nov 15, 2017 · 0 comments · Fixed by #2345
Closed

Add tests for String.trim on already-trimmed strings. #2340

jemc opened this issue Nov 15, 2017 · 0 comments · Fixed by #2345
Labels
help wanted Extra attention is needed

Comments

@jemc
Copy link
Member

jemc commented Nov 15, 2017 •
edited

Seeing #2336 made me realize that we don't seem to have tests for String.trim trimming a string that already had its null-terminator trimmed off of it. If we don't have these tests, we should add them for both trim and trim_in_place. Probably String.chop as well, once that is merged (#2337).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for String trimming on already-trimmed strings dipinhora/ponyc
2 participants
@SeanTAllen @jemc