Don't violate reference capabilities when assigning via a field #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When assigning to a field, the incoming value must be a subtype of the field type _without_ viewpoint adaptation.
SeanTAllen
added
the
triggers release
|
This should trigger a 0.10.0 release when it passes and is merged. |
|
There was a single failure in CI on Windows. Looks unrelated. I restarted that one job to verify. |
|
Before this gets merged, we should either do a manual CHANGELOG entry or change the title of this to better reflect what should be in the CHANGELOG. |
|
Passing! |
SeanTAllen
changed the title
SeanTAllen
added
the
changelog - fixed
SeanTAllen
changed the title
ponylang-main
added a commit
that referenced
this pull request
Dec 12, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assigning to a field, the incoming value must be a subtype of
the field type without viewpoint adaptation.
This addresses #1469.