Arrays as sequences #1741
Arrays as sequences #1741
Conversation
Previously, a comma ',' was used to separate array elements. In Pony, a comma is the tuple operator, and as a result, an array appeared to be composed of a tuple of elements. This change defines an array as a sequence of elements instead. As a result, no separator is needed when elements are on new lines, or a semicolon ';' (i.e. the sequence operator) can be used when elements are on the same line. This change means that all instances of ',' in Pony indicate a tuple (including, logically speaking, parameter lists, arguments, type arguments, etc.) and all instances of ';' indicate a sequence.
|
I'd like to hold on merging this until 0.11.4 is released so that it can go out without any breaking changes as that release is mostly about testing the new release scripts. |
| "\t" | ||
| Format.int[U64](nspo where width=10) | ||
| " ns/op" | ||
| ] |
There was a problem hiding this comment.
Quick style point to think about and discuss.
How would you feel about using the following bracket style for multi-line arrays in the standard library?
let sl = [
name
"\t"
Format.int[U64](ops where width=10)
"\t"
Format.int[U64](nspo where width=10)
" ns/op"
]Quite subjective, I know, but it feels more balanced to me, and also more consistent with the style being used for lambda curly braces so far.
packages/glob/_test.pony
Outdated
| @@ -99,14 +99,14 @@ class iso _TestFilter is UnitTest | |||
| fun name(): String => "files/Glob.filter" | |||
|
|
|||
| fun apply(h: TestHelper) ? => | |||
| let m = Glob.filter([ "12/a/Bcd", "12/q/abd", "34/b/Befd"], "*/?/B*d") | |||
| let m = Glob.filter([ "12/a/Bcd"; "12/q/abd"; "34/b/Befd"], "*/?/B*d") | |||
There was a problem hiding this comment.
I know it wasn't introduced in this PR, but this seems like a good opportunity to clean up the style inconsistency here for the space following the [, which isn't consistent with other single-line arrays in the standard library.
|
Also, does this need a change to |
|
Just FYI, if you've edited the changelog, you may see conflicts because we've now cut a 0.11.4 release. 😅 |
sylvanc
added
the
changelog - changed
|
Yes, needed a I'm afraid I'm a fan of the "leading delimiter on a line" approach. I suppose it's more ML/OCaml/F#, whereas "trailing delimiter on a line" is more C/C#/Java, so I can't really say my way is better, just that I'm a fan of it. I particularly like it when not binding to a variable, i.e.: fun greetings(): Array[String] =>
[ "hi"
"hello"
"aloha"
]And this extends to pipelining (not yet implemented of course), etc. |
I'm afraid, too! 😱 At any rate, I agree that it's subjective, and neither option is intrinsically better than the other in an absolute sense. It just makes me twitch a little bit. 😰 |
|
Mwahahaha: fun greetings(): Array[String] =>
[
"hi"
"hello"
"aloha"
]Don't mind me. |
|
@killerswan The madman! |
Previously, a comma ',' was used to separate array elements. In Pony, a
comma is the tuple operator, and as a result, an array appeared to be
composed of a tuple of elements.
This change defines an array as a sequence of elements instead. As a
result, no separator is needed when elements are on new lines, or a
semicolon ';' (i.e. the sequence operator) can be used when elements are
on the same line.
This change means that all instances of ',' in Pony indicate a tuple
(including, logically speaking, parameter lists, arguments, type
arguments, etc.) and all instances of ';' indicate a sequence.
Resolves #1736.