Fix tests being excluded or skipped unnecessarily. #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you kill the newline on 245? |
|
This was a bug in general @kulibali. Don't know how I missed it. Nice catch and a perfect reason once this is merged to test the latest release scripts again. |
SeanTAllen
reviewed
Mar 30, 2017
| @@ -242,19 +242,20 @@ actor PonyTest | |||
| """ | |||
| Run the given test, subject to our filters and options. | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
can you kill this? we generally start the first line of the method abutting the doc string.
|
Actually I want to get this onto master asap. Will clean up line 245 after. |
SeanTAllen
added a commit
that referenced
this pull request
Mar 30, 2017
|
Thank you for this @kulibali |
|
You're welcome! |
|
I'm horribly embarrassed. the best part of breaking ponytest is that it will pass CI. i dont know how when i can it locally it worked, i must have been in the wrong repo as i have a "ponyc" copy and a "sendence" copy. i hang my head in shame. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to
pony_test(51c11a3) compares test names to an_excludefield usingname.at(_exclude, 0). On Windows at least,String.at("", 0)always returnstrue(which is maybe a bug?), so all tests get excluded.This PR only excludes tests if the
_excludefield (and its related field_only) are non-empty.