Use deferred reification during code generation #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is a followup to abdcf2e and 884c62d. Instead of fully reifying each function before generating it, the code generator now reifies part of the function as needed. This further reduces the amount of AST duplication during compilation and will simplify the upcoming work on type-erased generics, which will in turn be used in the separate compilation work.
Praetonus
force-pushed
the
deferred-reify-3
branch
from
49dd91c
to
0d51e61
Compare
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
This change is a followup to abdcf2e and 884c62d. Instead of fully reifying each function before generating it, the code generator now reifies part of the function as needed. This further reduces the amount of AST duplication during compilation and will simplify the upcoming work on type-erased generics, which will in turn be used in the separate compilation work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a followup to abdcf2e and 884c62d. Instead of fully reifying each function before generating it, the code generator now reifies part of the function as needed.
This further reduces the amount of AST duplication during compilation and will simplify the upcoming work on type-erased generics, which will in turn be used in the separate compilation work.