Add llvm_config_{begin|end}.h #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate the special handling of including llvm headers into llvm_config_begin.h and llvm_config.end. Fix issue ponylang#2802
|
@kulibali, could you opine on this change. It has to do with disabling warnings when compiling code that includes LLVM headers and when using MSC. I think this streamlines the code things, putting the disabling of the warnings in one place and fixes #2802. In a future PR I'd like to add some additional code to llvm_config_begin.h that fixes #2776. Anyway, a review would be appreciated and rejecting this is perfectly fine. But I believe having the same set of disable warnings for each of the LLVM inclusions made sense and bounding the inclusion with two simple include statments looked cleaner to my eyes. Of course YMMV. |
chalcolith
approved these changes
Jun 25, 2018
|
@kulibali, Thanks |
|
Txs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate the special handling of including llvm headers into
llvm_config_begin.h and llvm_config.end.
Fix issue #2802