Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS on Intel as fully supported platform #4390

Merged
merged 6 commits into from Aug 17, 2023
Merged

Add macOS on Intel as fully supported platform #4390

merged 6 commits into from Aug 17, 2023

Conversation

SeanTAllen
Copy link
Member

Bringing it back as we are now running on GitHub Actions.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Aug 11, 2023
@SeanTAllen
Copy link
Member Author

First run cycle detector test crashed with bad access during release build. Second time, during debug but same thing.

@SeanTAllen SeanTAllen force-pushed the macos-x86 branch 2 times, most recently from 6021ca3 to f6bfaf5 Compare August 11, 2023 12:45
@SeanTAllen
Copy link
Member Author

@jemc @redvers does either of you have a x86 intel mac with ventura on it? if yes, can you try to verify the cycle-detector runner test failure that is reproducible in CI. So far, I haven't gotten it to happen in Monterey. We never did x86 Ventura on the code base before so this could very well be a real issue.

@redvers
Copy link
Contributor

redvers commented Aug 11, 2023

Unfortunately I'm still on Monterey and, as it's a corporately managed asset I don't have the ability to update it myself.

I'll checkin to see if the upgrade is pending.

@redvers
Copy link
Contributor

redvers commented Aug 11, 2023

Apparently the hardware I have (2015) is below the hardware cutoff Apple chose for Ventura. It will not be possible for me to test against ventura.

@SeanTAllen SeanTAllen force-pushed the macos-x86 branch 2 times, most recently from 41daaac to bf6c2ea Compare August 13, 2023 14:21
@SeanTAllen
Copy link
Member Author

Monterey went boom as well so we don't need Ventura to investigate apparently.

Bringing it back as we are now running on GitHub Actions.
@SeanTAllen SeanTAllen added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Aug 16, 2023
@SeanTAllen SeanTAllen requested a review from a team August 16, 2023 18:45
@SeanTAllen SeanTAllen changed the title Add macOS x86 support Add macOS on Intel as fully supported platform Aug 16, 2023
@SeanTAllen SeanTAllen marked this pull request as ready for review August 16, 2023 18:55
@SeanTAllen SeanTAllen merged commit e3905ed into main Aug 17, 2023
24 checks passed
@SeanTAllen SeanTAllen deleted the macos-x86 branch August 17, 2023 16:05
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Aug 17, 2023
github-actions bot pushed a commit that referenced this pull request Aug 17, 2023
github-actions bot pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants