Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Implement a full-usable frontend #8

Closed
dArignac opened this issue Oct 2, 2013 · 6 comments
Closed

Implement a full-usable frontend #8

dArignac opened this issue Oct 2, 2013 · 6 comments
Assignees
@mmrose
Labels
enhancement
Milestone
v0.3b2

Comments

@dArignac
Copy link
Member

dArignac commented Oct 2, 2013

Please do so ;-)
@ghost ghost assigned mmrose Oct 2, 2013
dArignac pushed a commit that referenced this issue May 21, 2014
restructured the display of a product and added a remove button #8
3b3234c
dArignac pushed a commit that referenced this issue May 21, 2014
added public_id to subscription for later deletion reference
4abf88c 
 added sceleton view and url for subscription deletion
 #8
@dArignac
Copy link
Member Author

To sum it up, that means the following things:

  • add/edit/delete email notifications
  • add/edit/delete subscription for one or more ASINs with each an email notification and a price

dArignac pushed a commit that referenced this issue May 26, 2014
now you're able to delete a subscription in frontend #8
e392107
@mmrose
Copy link
Member

mmrose commented May 7, 2015

Angular-Frontend is near a usable state. At the moment subscriptions on product detail page are not filtered by user.

dArignac added a commit that referenced this issue May 8, 2015
@dArignac
as the client side graphs require a lot of resources (the prices are …
6875d43 
…not limited in any way) and as we'll change to the new frontend soon, the graphs are disabled for now #8
dArignac added a commit that referenced this issue May 8, 2015
@dArignac
added utility function for getting the different product image urls w…
f247f54 
…ith respect to configured http or https #8
@dArignac
Copy link
Member Author

dArignac commented May 8, 2015

One more thing... ;)
The image urls are HTTP by default. But we have a setting PRICE_MONITOR_IMAGES_USE_SSL to enforce them via HTTPS. I can't remember how we solved this in the "old" master, there is this Product.__get_image_url method that changes the image host to HTTPS if configured but it was nowhere used. I added a method Product.get_image_urls to get all image URLs with correct schema for use in the old frontend, see f247f54. This has to be adapted for the angular frontend somehow.

@mmrose
Copy link
Member

mmrose commented May 9, 2015

It uses the properties again as this plays nicely together with serialization of DRF. I'm looking into that.

mmrose added a commit that referenced this issue May 10, 2015
@mmrose
Using protocol safe method to retrieve product images #8
2079b62
@mmrose
Copy link
Member

mmrose commented Jun 6, 2015

I would close this, as it is implemented and the rest should be done via new features or bugs, do you agree @dArignac ?

@dArignac
Copy link
Member Author

dArignac commented Jun 6, 2015

Agreed.

@mmrose mmrose closed this as completed Jun 6, 2015
@mmrose mmrose removed the in progress label Jun 6, 2015
@dArignac dArignac added this to the v0.3b1 milestone Sep 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mmrose mmrose

Labels
enhancement
Projects
None yet
Milestone
v0.3b2
Development

No branches or pull requests
2 participants
@dArignac @mmrose