Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isometric support and other improvements #18

Open
timothymtorres opened this issue Dec 22, 2018 · 5 comments
Open

Isometric support and other improvements #18

timothymtorres opened this issue Dec 22, 2018 · 5 comments

Comments

@timothymtorres
Copy link

Hi there @ldurniat and @superqix

I’ve been using a derivation of the Berry/ponytiled library and have added a few features that I feel like other developers might find useful.

The primary things are:

  • Support for Isometric tiles (both staggered and non staggered)
  • The ability to add objects/tiles/layers after the map has been loaded
  • Support for TexturePacker sprites and objects (WIP)

And a few misc changes.

@ldurniat your repo does not allow issues to be made so I guess the conversation will happen here. I’d hate having to work on code in a PR only for it to get turned down and wasted. I’m not really sure how different Berry/PT is from one another. Should I be trying to make changes to one or both libraries?

Also I would argue that some of methods for functions should be removed as they are nearly identical in some cases.

Map:getObjectWithName vs Map:getObjectsWithName

You should just delete the singular function IMO. Return the values in a table or just using commas and let the end user decide how to filter the data.

Also some functionality should change to be improved. Take the method ObjectLayer:getObject it has two arguments, name and objectType but the way the code is written prevents you from getting an object with just the objectType. You can get it by name or by using both arguments but not objectType.

Anyway, thank you both for the library and improvements made. I’m developing with Corona and there isn’t many resources for Tiled support. If you all want to talk about further code stuff we can use this Issue or you can catch me on my discord for the game I’m making at https://discord.gg/cnHUgMt

@superqix
Copy link
Member

I'd love to see how you approached TexturePacker support... I have some code that will use ShoeBox packed sprites, but I thought the process was a bit too complicated to push into this version. Just fork what you want and I'll have a look.

@timothymtorres
Copy link
Author

Alright I’ll do that. Christmas is coming up so give me around a week to clean it up a bit and I’ll publish the fork.

👍🏻👏🙏🏻

@ldurniat
Copy link
Contributor

Hi @timothymtorres,

I'm glad you like Berry:)

I added Issue tab to Berry project page.

Have a nice day:)

@timothymtorres
Copy link
Author

timothymtorres commented Jan 16, 2019

Alright I just got finished writing up a PR for @ldurniat that is about 90% complete. Once I have his library knocked out, I will start making the same changes to ponytiled @superqix . If you want a list of stuff I have added/changed I suggest you look at the pull request. I'm hoping to have the changes for berry finished within a week hopefully and then I can begin working on Ponytiled.

@superqix
Copy link
Member

Looks nifty... Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants