-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isometric support and other improvements #18
Comments
I'd love to see how you approached TexturePacker support... I have some code that will use ShoeBox packed sprites, but I thought the process was a bit too complicated to push into this version. Just fork what you want and I'll have a look. |
Alright I’ll do that. Christmas is coming up so give me around a week to clean it up a bit and I’ll publish the fork. 👍🏻👏🙏🏻 |
Hi @timothymtorres, I'm glad you like Berry:) I added Issue tab to Berry project page. Have a nice day:) |
Alright I just got finished writing up a PR for @ldurniat that is about 90% complete. Once I have his library knocked out, I will start making the same changes to ponytiled @superqix . If you want a list of stuff I have added/changed I suggest you look at the pull request. I'm hoping to have the changes for berry finished within a week hopefully and then I can begin working on Ponytiled. |
Looks nifty... Nice work! |
Hi there @ldurniat and @superqix
I’ve been using a derivation of the Berry/ponytiled library and have added a few features that I feel like other developers might find useful.
The primary things are:
And a few misc changes.
@ldurniat your repo does not allow issues to be made so I guess the conversation will happen here. I’d hate having to work on code in a PR only for it to get turned down and wasted. I’m not really sure how different Berry/PT is from one another. Should I be trying to make changes to one or both libraries?
Also I would argue that some of methods for functions should be removed as they are nearly identical in some cases.
Map:getObjectWithName
vsMap:getObjectsWithName
You should just delete the singular function IMO. Return the values in a table or just using commas and let the end user decide how to filter the data.
Also some functionality should change to be improved. Take the method
ObjectLayer:getObject
it has two arguments,name
andobjectType
but the way the code is written prevents you from getting an object with just theobjectType
. You can get it byname
or by using both arguments but notobjectType
.Anyway, thank you both for the library and improvements made. I’m developing with Corona and there isn’t many resources for Tiled support. If you all want to talk about further code stuff we can use this Issue or you can catch me on my discord for the game I’m making at https://discord.gg/cnHUgMt
The text was updated successfully, but these errors were encountered: