update to support SafeERC20 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
approved these changes
Jul 2, 2021
Merged
asselstine
reviewed
Jul 7, 2021
There was a problem hiding this comment.
Is this a dupe of https://github.com/pooltogether/sushi-pooltogether/pull/17/files?
I'm a little confused as to what the history of PRs is
@asselstine looks like it's the same first two commits yes. @asselstine ok so in this one, I've approved the max amount in the constructor and in the other one, I'll add the function to re-approve. |
PierrickGT
force-pushed
the
fix/112
branch
2 times, most recently
from
e54d56d
to
c31f9bd
Compare
asselstine
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code-423n4/2021-06-pooltogether-findings#112