Make Image Loading Asynchronous #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image buffering now happens in a separate long-running thread in the background, which receives image paths to load from a
Receiver, and sets the corresponding values within an atomic integer so that the state changes within the UI will know what's happening in the thread.When an image is being loaded, the button will be hidden, and replaced with a spinner.
And the background color & box shadow within the left panel has been unset.
The library will also re-use a pre-existing
Vec<u8>, truncating or extending it as required, rather than recreating a new one.Closes #8
Closes #11