Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Reset Mirrors to Defaults" button when the list is already at the default #76

Closed
jacobgkau opened this issue Oct 19, 2020 · 0 comments · Fixed by #85
Closed
Assignees
Labels
APT Issues pertaining to APT package management enhancement New feature or request

Comments

@jacobgkau
Copy link
Member

When X-Repolib-Default-Mirror is set, we show a "Reset Mirrors to Defaults" button:

reset-button

That button should probably be disabled when URIs is equal to X-Repolib-Default-Mirror, both to make it clear that it won't do anything in that case, and to provide more solid feedback after it's been used. (Disabling the button is probably better than hiding it, so users know they'll have the option of resetting to defaults before they start changing things.)

As of right now, the button prompts me for authentication even when it won't do anything, and I'm able to continue clicking it to no effect (when the list is already set to the default.)

@isantop isantop self-assigned this Oct 29, 2020
@isantop isantop added APT Issues pertaining to APT package management enhancement New feature or request labels Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APT Issues pertaining to APT package management enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants