Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaps round down to powers of 4 #51

Closed
leviport opened this issue Mar 4, 2020 · 3 comments
Closed

Gaps round down to powers of 4 #51

leviport opened this issue Mar 4, 2020 · 3 comments

Comments

@leviport
Copy link
Member

leviport commented Mar 4, 2020

I think this is intentional, but I can't set a gap value that isn't a multiple of 4. If the value entered isn't a multiple of 4, it sets it to the next lowest multiple of 4. This seems pretty reasonable, although I wonder if true rounding would be more user-friendly than rounding down each time. For example, if I enter 7, it sets it to 4. Would 8 be better since it's closer to the number the user entered?

@mmstick
Copy link
Member

mmstick commented Mar 4, 2020

Perhaps. If the difference is > 2, I will round up.

@mmstick
Copy link
Member

mmstick commented Mar 4, 2020

Implemented in c1e25e5

@leviport
Copy link
Member Author

leviport commented Mar 5, 2020

Confirmed fix, much better now 👍

@leviport leviport closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants