Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop!_Shop category banners are broken when using a non-default GTK3 theme #124

Closed
bucklingspring opened this issue May 3, 2019 · 4 comments

Comments

@bucklingspring
Copy link

Distribution: Pop!_OS 19.04

Related Application and/or Package Version: pop-shop 3.0.1~1554755308~19.04~3a86893

Issue/Bug Description: When using a non-default GTK3 theme, the Pop!_Shop category banners are missing backgrounds and appropriate icons.

Steps to reproduce: Change the GNOME application theme from 'Pop' to Adwaita, HighContrast, or any custom theme downloaded from the internet.

Expected behavior: The banners should be identical to the default look across all GNOME application themes.

ZKqTlxYPcPYVcyc4-biwXLEfqQFdHgm5ZmEU17ZxgJo

@mmstick
Copy link
Member

mmstick commented May 3, 2019

GTK themes must support elementary Granite style classes in order to function with the shop.

@mmstick mmstick closed this as completed May 3, 2019
@cassidyjames
Copy link

The color palette is not part of Granite, but is part of the elementary Stylesheet. Technically it has nothing to do with Granite.

@pedrofleck
Copy link

Couldn't it fallback to default colours when the theme doesn't provide them? I really like Pop but I wish I could use Adwaita with it

@bucklingspring
Copy link
Author

Couldn't it fallback to default colours when the theme doesn't provide them? I really like Pop but I wish I could use Adwaita with it

I agree, this would be very nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants