Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Pop!_OS Shell #67

Closed
lolrepeatlol opened this issue Aug 7, 2020 · 3 comments
Closed

Issues with Pop!_OS Shell #67

lolrepeatlol opened this issue Aug 7, 2020 · 3 comments

Comments

@lolrepeatlol
Copy link

Hello. I really appreciate your work in keeping Arc alive. Unfortunately, I installed Pop!_OS on my computer, and it has issues with the theme. The developers of this distro seemingly make some annoying modifications to GNOME that break certain themes, including Arc :(. Unfortunately to fix these issues I think they need to be coded around, like Nordic does. I even tried to install normal Gnome but it seems to have the same issues as the Pop desktop has. Like many themes, it also has issues with the Pop Shop's banners. I looked this up, and apparently theme developers need to fix this themselves.

Here are some attached screenshots. I think they speak for themselves, but I will happily make more screenshots or describe extra issues if you'd like.

I tried building from source and using the Debian package, but both have similar issues. I would happily help you fix this issue if you're okay with that.

  • Distribution and version: Pop!_OS 20.04
  • Versions for the affected applications/desktops/tookits: Gnome Shell 3.26

Thanks! :)

@jnsh
Copy link
Owner

jnsh commented Aug 7, 2020

The issues with the shell were regressions with gnome 3.36 (not 3.26) or earlier, and shouldn't be present as long as the theme has been built for the correct gnome-shell version.

The problem with pop OS store, based on the comment by cassidyjames and from having a brief look at the pop shop code, is that the application is using non-standard color definitions that are only present in the elementary GTK theme. Please test if the issue is present with the default Adwaita GTK theme. If the category buttons are displayed correctly with it, I'll have another look. If the buttons look incorrect also when using Adwaita, this should certainly be fixed within the application, and not in the theme.

@lolrepeatlol
Copy link
Author

HAHAHAHHAHAHAHAHAHAHAHHAHA YOU'RE RIGHT! I built for 3.26. Thanks, I would not have figured out otherwise.

Also, yes, I tested with Adwaita and it has the same issues with the store unfortunately.

@jnsh
Copy link
Owner

jnsh commented Aug 7, 2020

Happy to hear you got it sorted out.

Also, yes, I tested with Adwaita and it has the same issues with the store unfortunately.

Thanks for checking. I'd recommend reporting this to the Pop Shop developers again, explaining that the problem exists with the default GTK theme, and not only with custom 3rd party themes. AFAIC, all GTK applications should be built to work with Adwaita first and foremost, and the Pop shop developers should definitely take a note.

Closing this, since the pop shop issue should be considered an upstream bug. Thanks for letting me know regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants