#191 incorporate stylelint part two #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay nicely with webpack.
…or I'm doing something wrong.
The default `stylelint` module wants to load configuration files from the filesystem in a dynamic way that isn’t possible with `brfs`. We don’t actually need the file-loading behavior, so instead, we hand-roll a `stylelint` object in the same manner as [`createStylelint`](https://github.com/stylelint/stylelint/blob/7.5.0/src/createStylelint.js), but using configuration defined in code rather than the filesystem. This definitely builds in knowledge of some non-public APIs in `stylelint`, but I can’t think of a better approach. Also a decent amount of Webpack wrangling to get the modules we do import from stylelint to build. In particular, they *still* want to hit the filesystem, although they don’t actually need to in order to work for us. So, instead of building those modules with `brfs`, just use the string replace loader to turn `require("fs")` into a null object; use the `substitute` loader to stub out the `isAutoprefixable` method; and use the null module loader to stub out rules that want access to a gigantic database of browser capabilities. The usage of string-replacement is a fragile hack, but I can’t think of another way to *only* stub out `fs` in that particular context.
Browser-friendly stylelint build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally closed PR #553 when I deleted the remote branch while rebasing.
Hopefully it doesn't happen with the other PR #514