No error prompt on closing curly brace in CSS section #191
Assignees
Labels
Comments
|
I think the fix for this is to incorporate |
|
@jwang1919 this would be useful and possibly juicy and fun if you are looking for a meaty contribution! |
|
I'll work on it the week after. I got other commitments this weekend 😄 . |
|
@outoftime please assign this to me. I can't find any option to do so myself. I'll start doing some basic digging into this issue. |
|
@jwang1919 all yours!! |
jwang1919
added a commit
to jwang1919/popcode
that referenced
this issue
Nov 12, 2016
This was referenced Nov 13, 2016
jwang1919
added a commit
to jwang1919/popcode
that referenced
this issue
Nov 13, 2016
….com/jwang1919/popcode into popcodeorg#191-incorporate-stylelint
jwang1919
added a commit
to jwang1919/popcode
that referenced
this issue
Nov 13, 2016
outoftime
added a commit
to jwang1919/popcode
that referenced
this issue
Nov 18, 2016
outoftime
pushed a commit
that referenced
this issue
Nov 18, 2016
* Initial commit. Added stylelint to npm package. Still getting it to play nicely with webpack. * Still broken. Webpack seems to be unable to load stylelint properly, or I'm doing something wrong. * Browser-friendly stylelint build The default `stylelint` module wants to load configuration files from the filesystem in a dynamic way that isn’t possible with `brfs`. We don’t actually need the file-loading behavior, so instead, we hand-roll a `stylelint` object in the same manner as [`createStylelint`](https://github.com/stylelint/stylelint/blob/7.5.0/src/createStylelint.js), but using configuration defined in code rather than the filesystem. This definitely builds in knowledge of some non-public APIs in `stylelint`, but I can’t think of a better approach. Also a decent amount of Webpack wrangling to get the modules we do import from stylelint to build. In particular, they *still* want to hit the filesystem, although they don’t actually need to in order to work for us. So, instead of building those modules with `brfs`, just use the string replace loader to turn `require("fs")` into a null object; use the `substitute` loader to stub out the `isAutoprefixable` method; and use the null module loader to stub out rules that want access to a gigantic database of browser capabilities. The usage of string-replacement is a fragile hack, but I can’t think of another way to *only* stub out `fs` in that particular context. * Fix npm test errors after merge from outoftime's browser-friendly stylelint build * Working stylelint build with validations * Merged from master branch * Refactored stylelint.js. Fixed _locationForError function so it's working properly. * Changed code to follow PR#514 suggestions.
|
Fixed by #556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Popcode will read the following CSS as valid with no error prompt.
p { color: black;The text was updated successfully, but these errors were encountered: