Fixing #617 #628
Merged
Fixing #617 #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poppastring
requested changes
Apr 14, 2022
There was a problem hiding this comment.
Hi! Thanks for the PR!
Changes should be to this file only to support this update:
\source\DasBlog.Web.UI\TagHelpers\Post\PostReadTimeTagHelper.cs
Hopefully you are using Visual Studio. There are instructions here: https://github.com/poppastring/dasblog-core/blob/main/CONTRIBUTING.md#developers
I think you have inadvertently added this to a project file.
Please also rollback all the deletes also, if these files really are unnecessary, we can deal with that by adding a bug and creating a PR.
Thanks!
- Deleting code from DasBlogAll; - Adding code for review to .../PostReadTimeTagHelper file;
This reverts commit 3596e91.
poppastring
approved these changes
Apr 27, 2022
|
@tsdamas Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @poppastring
I hope I made the pull request correctly. Please apologize in advance if not.
Please also let me know what you think and you feedback is very much appreciate it. :)
I believe using the regex was the way to go, as you mentioned. I create a foreach loop to go over the Post.Content and count the matches it found. I hope it fix the bug, if not please let me know and I will try to get other solution or improve this one.
Have a great one!