Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation of static pages as per #686. #688

Merged
merged 1 commit into from Sep 2, 2023

Conversation

thousandtyone
Copy link
Contributor

@thousandtyone thousandtyone commented Aug 27, 2023

Simple Implementation (v1):

This is the basic implementation as discussed in #686.

Once the merge is done testing is really simple.

  1. In your content folder, create a folder called "static" inside your content folder (wherever that is configured). e.g.
    image

  2. Inside the static folder keep a ".html" file with simple HTML:
    image

  3. It can hold any static HTML:
    image

  4. Save the File, run the blog, and now replace ".html" either with ".aspx" or nothing (depending on your blog's routing scheme):
    image

  5. Of course if you are using aspx based URL scheme (older migrations of historic blogs with URLs retained) you can also retain the URL of your static page and use ".aspx" in the end:
    image

Next Steps:

Once this PR is approved I will be working on:

  1. Test Cases.
  2. Caching (this would be better than reading from the file) - in the long run, we should do file-dependency caching so that files are not read till changes are made.
  3. Maybe even a front end for creating and managing these pages? (if there is a real demand/need for that).
  4. For now I've not removed the about-us implementation that already exists. I can remove it if we all agree that this feature makes that one redundant.

Please do let me know if any added changes are required. Happy to make those.

@poppastring
Copy link
Owner

@thousandtyone This looks good!

@poppastring poppastring merged commit 2e450a9 into poppastring:main Sep 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants