Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to/from ms format? #74

Closed
jeromekelleher opened this issue Nov 12, 2020 · 2 comments · Fixed by #354
Closed

Conversion to/from ms format? #74

jeromekelleher opened this issue Nov 12, 2020 · 2 comments · Fixed by #354
Labels
enhancement New feature or request
Milestone

Comments

@jeromekelleher
Copy link
Member

I'm guessing that a lot of people will want to be able to either convert their existing models to demes or to run demes models through simulators that support ms's demographic model description.

Should we provide from_ms() and to_ms() methods? (Or similarly named?)

The from_ms code wouldn't be too bad, as we could adapt the command line parsing code in msprime. With a few small adjustments (i.e., raising ValueErrors rather than calling sys.exit) I think we could reuse the argparse code directly, which doesn't have to actually be used in the context of a CLI.

I've been thinking about doing this for the msprime 1.0 Demography API, but it seems to me it would be much more useful here.

Thoughts?

@grahamgower
Copy link
Member

Yes, that would be an excellent addition.

@jeromekelleher
Copy link
Member Author

Good stuff. I'm updating the msprime CLI code at the moment to modernise, so let's not take this on for a bit.

@grahamgower grahamgower added demes-python enhancement New feature or request labels Nov 17, 2020
grahamgower pushed a commit to jeromekelleher/demes that referenced this issue Apr 15, 2021
grahamgower added a commit to grahamgower/demes-python that referenced this issue Jul 9, 2021
@grahamgower grahamgower mentioned this issue Jul 9, 2021
@grahamgower grahamgower modified the milestones: 0.1.3, 0.2.0 Jul 9, 2021
grahamgower added a commit to grahamgower/demes-python that referenced this issue Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants