Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drosophila dfe #1046

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Conversation

izabelcavassim
Copy link
Member

Adding a new gamma DFE for Drosophila based on Huber et al., 2017
following the issue described in #1040
Please have a look at it @petrelharp and let me know if I need to do any modifications.
Thank you!

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #1046 (4fcca0a) into main (da3e351) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          89       90    +1     
  Lines        2887     2902   +15     
  Branches      346      346           
=======================================
+ Hits         2873     2888   +15     
  Misses          6        6           
  Partials        8        8           
Impacted Files Coverage Δ
stdpopsim/catalog/DroMel/__init__.py 100.00% <100.00%> (ø)
stdpopsim/catalog/DroMel/dfes.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da3e351...4fcca0a. Read the comment docs.

@andrewkern
Copy link
Member

this looks good to me @izabelcavassim. can you please rebase and squash these commits before we merge? i think i can use the github interface myself to do that in this case but don't want to screw it up...

@andrewkern andrewkern merged commit 80dbefe into popsim-consortium:main Oct 21, 2021
@andrewkern
Copy link
Member

awesome @izabelcavassim!

@petrelharp
Copy link
Contributor

Looks good! I'll open a QC issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants