You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've renamed the model GabonAg1000G_1A17, since the string is supposed to be "descriptive", and "GAS" is just the internal code used for Gabon. I've also decided not to put all 110 epoch times and demographic sizes in the summary table. I ran into no problems!
Merging #1279 (09fd16a) into main (a98b3f0) will increase coverage by 0.20%.
The diff coverage is 100.00%.
❗ Current head 09fd16a differs from pull request most recent head 997ff8b. Consider uploading reports for the commit 997ff8b to get more accurate results
So - I got the same model, but then I tried to remove the "epochs" in the model in which nothing changes - i.e., the zero-length epochs and the ones where the population size is the same as before. Now, things don't pass, and someone else ought to fix up the original model. Might you be able to have a go at this, @andrewkern?
Never mind! I got it! Simplified the model in the code by some careful hand editing, and it agrees with the programatic solution in QC. I think tihs is ready to go!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1278.
I've renamed the model
GabonAg1000G_1A17, since the string is supposed to be "descriptive", and "GAS" is just the internal code used for Gabon. I've also decided not to put all 110 epoch times and demographic sizes in the summary table. I ran into no problems!