Add missing citations for AraTha and EscCol. #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 21 21
Lines 1902 1904 +2
Branches 202 202
=======================================
+ Hits 1896 1898 +2
Misses 2 2
Partials 4 4
Continue to review full report at Codecov.
|
|
I think this is ready to merge after a rebase. |
|
Ok, merging. Thanks @jeromekelleher and @fbaumdicker! |
This was referenced May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #355.
Theses species were added by @fbaumdicker and @arundurvasula --- would you be kind enough to quickly check that I haven't messed anything up here? Note that for AraTha, the recombination rate was listed as 8.1e-9, but I get
200 / 124000 / 2 / 1e6 = 8.064516129032258e-10.