Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set host root on system service init #35

Merged
merged 9 commits into from
Nov 19, 2018
Merged

Conversation

chiptus
Copy link
Contributor

@chiptus chiptus commented Nov 11, 2018

set ghw env vars on system service init.

Fixes #34

@chiptus
Copy link
Contributor Author

chiptus commented Nov 11, 2018

related issue in jaypipes/ghw: jaypipes/ghw#86

@deviantony
Copy link
Member

@chiptus I've been able to build and push an image for our customer to test based on the latest version of this branch and it finally fixes their issue.

What's the status on this (regarding external dependencies mainly) and what do we need/wait to merge it?

@deviantony
Copy link
Member

Let's validate with this dependency update: jaypipes/ghw#88

@deviantony
Copy link
Member

Ok, sent a build to the customer and waiting for his approval.

@deviantony
Copy link
Member

Confirmed working.

Copy link
Member

@deviantony deviantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deviantony deviantony merged commit d61ff61 into develop Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants