Support specifying options in module constructors #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the instantiation of a possibly incomplete HostInfo struct from the Host() function implementation, only returning a complete HostInfo struct if all member fields have been properly constructed.
There were a few places where the memory_linux.go module was still relying on hard-coded filepaths and not using the path_linux.go functions to append the GHW_CHROOT path properly. Since the next patch will add support for passing chroot as options, this patch gets those straggler hard-coded paths sorted.
Each module (CPU(), Memory(), Network(), etc...) now supports calling
the main module constructor with zero or more pointers to WithOption
structs. There is only a single option (the CHROOT value for path
construction) but I've designed it so the system is flexible for future
additional options without needing to change the calling interface.
To specify a chroot override for a particular module, use the
WithChroot() function, like so:
```go
mem, err := ghw.Memory(WithChroot("/host"));
```
Issue #86
|
@deviantony @chiptus if you have the opportunity to pull this commit (78e8fd3) and test it in your environment before I merge, that would be great. :) |
|
@jaypipes we will test this PR in our env, thanks ! |
|
@jaypipes, thanks for all your work, we really appreciate it. our problem is mostly with pcidb, so we can't test it until the new version of pcidb is in. |
|
Ah, OK. Let me do the remaining work for pcidb, cut a release and then use the new release in ghw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each module (CPU(), Memory(), Network(), etc...) now supports calling
the main module constructor with zero or more pointers to WithOption
structs. There is only a single option (the CHROOT value for path
construction) but I've designed it so the system is flexible for future
additional options without needing to change the calling interface.
To specify a chroot override for a particular module, use the
WithChroot() function, like so:
Issue #86