Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-37565 | Add missing fields in Helm for CSI #588

Merged
merged 15 commits into from
Jul 25, 2024
Merged

Conversation

hitesh-wani-px
Copy link
Collaborator

What this PR does / why we need it:
This PR will add missing field in the helm for CSI
Which issue(s) this PR fixes (optional)
Closes #https://purestorage.atlassian.net/browse/PWX-37565

Special notes for your reviewer:

…geCluster template

Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
@hitesh-wani-px hitesh-wani-px force-pushed the PWX-37565 branch 2 times, most recently from 994336f to fbef38c Compare June 24, 2024 10:38
@hitesh-wani-px
Copy link
Collaborator Author

hitesh-wani-px commented Jun 25, 2024

Testing Notes:

  1. Disabling CSI
    csi: 
       enabled: false                     
       topology:  
          enabled: false                    
       installSnapshotController: false 
    Generated storageCuster spec
       # Source: portworx/templates/storage-cluster.yaml
       kind: StorageCluster
       apiVersion: core.libopenstorage.org/v1
       metadata:
         name: "mycluster"
         namespace: portworx
         annotations:
         labels:
           heritage: "Helm"
           release: "my-release"
           chart: "portworx-3.1.0"
           app.kubernetes.io/managed-by: "Helm"
           app.kubernetes.io/instance: "my-release"
       spec:
         image: portworx/oci-monitor:3.1.0
         imagePullPolicy: Always
    
         kvdb:
           internal: true
         storage:
           useAll: true
         secretsProvider: k8s
    
         env:
         - name: PX_SECRETS_NAMESPACE
           value: portworx
    
         stork:
           enabled: true
         csi:
           enabled: false
  2. Enabling CSI
    1. Enable topology
      csi: 
        enabled: true                     
        topology: 
            enabled: true                     
        installSnapshotController: false
      Generated storageCluster Spec
      kind: StorageCluster
      apiVersion: core.libopenstorage.org/v1
      metadata:
        name: "b12de6b1-a167-48f4-9a0d-e7b2ab0dbc74"
        namespace: portworx
        annotations:
        labels:
          heritage: "Helm"
          release: "my-release"
          chart: "portworx-3.1.0"
          app.kubernetes.io/managed-by: "Helm"
          app.kubernetes.io/instance: "my-release"
      spec:
        image: portworx/oci-monitor:3.1.0
        imagePullPolicy: Always
      
        kvdb:
          internal: true
        storage:
          useAll: true
        secretsProvider: k8s
      
        env:
        - name: PX_SECRETS_NAMESPACE
          value: portworx
      
        stork:
          enabled: true
        csi:
          enabled: true
          topology:
            enabled: true
          installSnapshotController: false
    2. Enable snapshotter controller
      csi: 
        enabled: true                      
        installSnapshotController: true    
      Generated storageCluster spec
      kind: StorageCluster
      apiVersion: core.libopenstorage.org/v1
      metadata:
        name: "db1bb375-75f0-4bc9-9a2a-df09ecbd36f1"
        namespace: portworx
        annotations:
        labels:
          heritage: "Helm"
          release: "my-release"
          chart: "portworx-3.1.0"
          app.kubernetes.io/managed-by: "Helm"
          app.kubernetes.io/instance: "my-release"
      spec:
         image: portworx/oci-monitor:3.1.0
         imagePullPolicy: Always
      
        kvdb:
           internal: true
        storage:
          useAll: true
        secretsProvider: k8s
      
        env:
        - name: PX_SECRETS_NAMESPACE
           value: portworx
      
        stork:
           enabled: true
        csi:
          enabled: true
          installSnapshotController: true

Unit test cases results:

--- PASS: TestStorageClusterHelmTemplate (0.00s)
    --- PASS: TestStorageClusterHelmTemplate/TestCSITopologyEnabled (0.09s)
    --- PASS: TestStorageClusterHelmTemplate/TestCSISnapshotControllerEnabled (0.09s)
    --- PASS: TestStorageClusterHelmTemplate/TestDefaultChartValues (0.09s)
    --- PASS: TestStorageClusterHelmTemplate/TestPlacementTolerations (0.10s)
    --- PASS: TestStorageClusterHelmTemplate/TestExternalETCD (0.10s)
    --- PASS: TestStorageClusterHelmTemplate/TestCustomRegistry (0.10s)
    --- PASS: TestStorageClusterHelmTemplate/TestAllComponentsEnabled (0.10s)
PASS
ok      github.com/portworx/helm/test/portworx  0.125s

@hitesh-wani-px hitesh-wani-px force-pushed the PWX-37565 branch 2 times, most recently from 5aad08b to 1f47f09 Compare June 25, 2024 05:47
@hitesh-wani-px hitesh-wani-px changed the title Add missing fields in Helm for CSI PWX-37565 | Add missing fields in Helm for CSI Jun 25, 2024
@hitesh-wani-px hitesh-wani-px changed the base branch from master to PWX-29986 June 26, 2024 06:19
@nikita-bhatia
Copy link

nikita-bhatia commented Jun 26, 2024

@hitesh-wani-px

  • Please change the base branch to feature branch for helm : PWX-29986
  • Rebase the PR's branch to testing framework branch
  • Add UTs for the CSI component

Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
px-kesavan and others added 11 commits June 27, 2024 14:45
Signed-off-by: kesavan thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>

2.7.0 tar
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
update bundle for 2.7.1

update bundle for 2.7.1
Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
@hitesh-wani-px hitesh-wani-px marked this pull request as draft July 5, 2024 05:58
@hitesh-wani-px hitesh-wani-px marked this pull request as ready for review July 5, 2024 05:58
Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
Copy link

@nikita-bhatia nikita-bhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hitesh-wani-px hitesh-wani-px merged commit 26b38a2 into PWX-29986 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants