-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWX-37565 | Add missing fields in Helm for CSI #588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geCluster template Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
hitesh-wani-px
force-pushed
the
PWX-37565
branch
2 times, most recently
from
June 24, 2024 10:38
994336f
to
fbef38c
Compare
Testing Notes:
Unit test cases results:
|
hitesh-wani-px
force-pushed
the
PWX-37565
branch
2 times, most recently
from
June 25, 2024 05:47
5aad08b
to
1f47f09
Compare
hitesh-wani-px
changed the title
Add missing fields in Helm for CSI
PWX-37565 | Add missing fields in Helm for CSI
Jun 25, 2024
|
hitesh-wani-px
requested review from
nikita-bhatia,
vinayakshnd and
diptiranjanpx
June 26, 2024 06:42
Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
hitesh-wani-px
force-pushed
the
PWX-37565
branch
from
June 26, 2024 12:21
1f47f09
to
17be345
Compare
Signed-off-by: kesavan thiruvenkadasamy <kthiruvenkadasamy@purestorage.com> 2.7.0 tar
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
update bundle for 2.7.1 update bundle for 2.7.1
Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
diptiranjanpx
approved these changes
Jul 23, 2024
test/portworx/testValues/storagecluster_all_components_enabled.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: hitesh-wani-px <hwani+github@purestorage.com>
nikita-bhatia
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will add missing field in the helm for CSI
Which issue(s) this PR fixes (optional)
Closes #https://purestorage.atlassian.net/browse/PWX-37565
Special notes for your reviewer: