Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Add gen 7 Pokémon images #652

Merged
merged 2 commits into from
Feb 14, 2017
Merged

Add gen 7 Pokémon images #652

merged 2 commits into from
Feb 14, 2017

Conversation

Raia
Copy link
Member

@Raia Raia commented Feb 14, 2017

Progress:

  • Add gen 7 large sprites
  • Add gen 7 minisprites

Notes:

I avoided uploading unnecessary duplicates for Minior, so we'll need to handle its forms differently. All Minior-Meteor share the same sprite; same with all shiny Minior-Core.

/regular/774-meteor.png
/shiny/774-meteor.png
/shiny/774-shiny.png

Copy link
Contributor

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merge this one in and get the mini sprites in another one. We don't need PRs to be perfect. IF they don't break any existing functionality, then it's good.

Copy link
Contributor

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I just tried these and realised they are 256x256. The gen 6 ones we have are 120x120.

edit: If we scale them down, the small ones look really small, and if we trim off some of it, then we lose some of the bigger ones :-\

Copy link
Contributor

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind. Scaling looks fine. Either add

.pokemon-container img { width: 120px; } or I'll add it into my branch. Either way, happy.

@Raia
Copy link
Member Author

Raia commented Feb 14, 2017

@YaManicKill, I'll let you take care of it in your branch. Will merge after tests are done.

@Raia Raia merged commit 21cc46f into master Feb 14, 2017
@Raia Raia deleted the 542-pokemon-images branch February 14, 2017 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants