Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework "check if page exists" #71

Open
4 tasks
posativ opened this issue Mar 3, 2014 · 1 comment
Open
4 tasks

rework "check if page exists" #71

posativ opened this issue Mar 3, 2014 · 1 comment
Labels
needs-contributor Someone needs to implement this. Help wanted! server (Python) server code
Milestone

Comments

@posativ
Copy link
Collaborator

posativ commented Mar 3, 2014

Currently, Isso uses the browser-provided "Origin" that matches its internal host list (or the first as fallback if no match) to send a GET request to the requested page. If the request succeeds, comments can be posted to that page.

However this has several drawbacks: if – for some reasons – Isso can not connect to the internet, new comments always fail with a "Not Found" response. Secondly, Isso is not limited to a sub url e.g /foo, it happily takes comments for /bar as well.

Roadmap:

  • default thread provider: fetch URL if not in database, extract title or fallback to isso-title attribute. Use browser origin or try a custom host.
  • new thread provider: map relative URI to filesystem (e.g. to static blog)
  • also introduce a dummy provider that happily accept comments on everything without any network activity
  • write functional tests
@Hywan
Copy link

Hywan commented Jan 20, 2015

👍

@ix5 ix5 added needs-contributor Someone needs to implement this. Help wanted! server (Python) server code labels Feb 10, 2022
@ix5 ix5 modified the milestones: 1.0, backburner Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-contributor Someone needs to implement this. Help wanted! server (Python) server code
Projects
None yet
Development

No branches or pull requests

3 participants