-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2021_Saag_EastEuropean - SOP002 - EstCWC has broken genotype data #5
Comments
I don't know if it is only one individual, but the convertf issue I mentioned in our meeting was: |
Aha! So this is linked to the issue you mentioned. Would be great if this could be fixed. Don't worry about the rest of the packages though - we will have to automate this validation anyway (see #6) |
Aha OK, thank you @AyGhal, that helps a lot. I will check whether my current handling of this is too strict. Perhaps I make a tacit assumption that the first allele would always be reference (didn't think so, though). |
OK, I checked. I'm definitely not assuming anything. This is really a hard error because apparently in this genotype data there is a Hom-Ref genotype at a position where the first allele is missing (0). Of course, one way to deal with this without throwing an error is to simply mark the genotype in such a case as missing... but I'm worried that I'm missing something here... |
You can reproduce the error with this code:
|
I just pushed an update to poseidon-hs (bumped version to 0.14.1), which should at least now give more helpful error messages also indicating which SNP caused the error. If you have time to explore this further, feel free, otherwise I'll have time tonight to check myself. |
@AyGhal it's clear now that the data for this package is broken. I doubt that any of our main tools caused this, and I blame simply the combination of conversion steps that were necessary for creating this dataset. Could you generate a new dataset either using |
Okay, but is the second one also broken? |
What do you mean by "second one"? |
The one I prepared on Friday, I will share the link. |
OK, I think that works now! |
OK, so I've just tried to forge your new package under |
@AyGhal could you make sure that this new package is correctly in our local SDAG poseidon repo? And also make any necessary updates to the public repo (pull request...). Also, please update the package version. When all that is done I'll replace the version on the server. Thanks! |
I guess that is solved now. 👍 |
Something is wrong with this specific individual, possibly the whole package.
trident forge
stops withencountered illegal genotype Hom-Ref with Ref-Allele missing
if this individual is included.Any ideas, @AyGhal and @stschiff?
The text was updated successfully, but these errors were encountered: