Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining examples for express API reference #1093

Merged
merged 18 commits into from
Feb 2, 2024
Merged

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Feb 1, 2024

Closes #1080

@gadenbuie want to add the handful of update_*() examples you did?

@gadenbuie gadenbuie marked this pull request as ready for review February 1, 2024 13:12
@gadenbuie
Copy link
Collaborator

@cpsievert I added the remaining examples and took out the guardrails so that from now on missing examples in Express docs will throw in CI.

I also realized we hadn't accounted for Express functions being documented in the Core reference, so I updated the logic to automatically pick app-express.py for functions under shiny/express, even if we're in Core mode.

@cpsievert
Copy link
Collaborator Author

I also realized we hadn't accounted for Express functions being documented in the Core reference

Oh, good catch, this is actually an oversight on my part...I think it'd be best not to include those Express functions in the Core docs?

docs/_renderer.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions above, and maybe a couple of accidentally included files.

(I didn't read every line but I did skim all of the files.)

@cpsievert cpsievert merged commit a3389df into main Feb 2, 2024
25 of 26 checks passed
@cpsievert cpsievert deleted the express-api-examples branch February 2, 2024 17:24
schloerke added a commit that referenced this pull request Feb 13, 2024
* main:
  Bump version to 0.7.1.9000
  Fix input_task_button for modules (#1108)
  Bump version to 0.7.1
  Test input task button and extended task decorator (#1099)
  Add remaining examples for express API reference (#1093)
  test: Add `make playwright-debug` to help debug playwright tests (#1097)
  Make input_selectize work correctly within a module (#1091)
  Update types to allow `navset_*` functions to accept `MetadataNode` args (#1094)
  Update changelog
  Update express.ui.hold() to accept any type of object (#1089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add express examples for remaining express functions
2 participants