Test input task button and extended task decorator #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
requested changes
Feb 2, 2024
| @@ -24,11 +24,18 @@ async def slow_compute(a: int, b: int) -> int: | |||
| return a + b | |||
|
|
|||
There was a problem hiding this comment.
Let's move these testing changes to a local test app, rather than updating the api-examples.
There was a problem hiding this comment.
Sorry for suggesting the updates here and not in the local test app. (This file should not be changed in the PR.)
tests/playwright/shiny/inputs/input_task_button/test_input_task_button.py
Show resolved
Hide resolved
tests/playwright/shiny/inputs/input_task_button/test_input_task_button.py
Show resolved
Hide resolved
tests/playwright/shiny/inputs/input_task_button/test_input_task_button.py
Outdated
Show resolved
Hide resolved
tests/playwright/shiny/inputs/input_task_button/test_input_task_button.py
Outdated
Show resolved
Hide resolved
tests/playwright/shiny/inputs/input_task_button/test_input_task_button.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Barret Schloerke <barret@posit.co>
Co-authored-by: Barret Schloerke <barret@posit.co>
Co-authored-by: Barret Schloerke <barret@posit.co>
Co-authored-by: Barret Schloerke <barret@posit.co>
…k_button.py Co-authored-by: Barret Schloerke <barret@posit.co>
…k_button.py Co-authored-by: Barret Schloerke <barret@posit.co>
…k_button.py Co-authored-by: Barret Schloerke <barret@posit.co>
…k_button.py Co-authored-by: Barret Schloerke <barret@posit.co>
…k_button.py Co-authored-by: Barret Schloerke <barret@posit.co>
Co-authored-by: Barret Schloerke <barret@posit.co>
schloerke
approved these changes
Feb 2, 2024
schloerke
added a commit
that referenced
this pull request
Feb 13, 2024
* main: Bump version to 0.7.1.9000 Fix input_task_button for modules (#1108) Bump version to 0.7.1 Test input task button and extended task decorator (#1099) Add remaining examples for express API reference (#1093) test: Add `make playwright-debug` to help debug playwright tests (#1097) Make input_selectize work correctly within a module (#1091) Update types to allow `navset_*` functions to accept `MetadataNode` args (#1094) Update changelog Update express.ui.hold() to accept any type of object (#1089)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test both blocking and non-blocking operations using playwright test