Change `express.layout` to `express.ui` #904

wch · 2023-12-13T01:25:07Z

This PR changes the name of express.layout to express.ui, as described in #854 (comment).

It also adds a test to make sure that all items from shiny.ui are accounted for in shiny.express.ui, and vice versa. For both of these modules, either a corresponding item must exist in both modules, or it must be listed explicitly in a variable _known_missing.

There are a few remaining API questions:

For some functions, like card_header(), it's not clear to me whether they should be context managers or regular functions.
shiny.ui.page_navbar() takes a named argument sidebar, which comes after the *args. The express version of this function also takes a named argument sidebar, but the only way to use it is with something like this, which is really awkward:
```
s = shiny.ui.sidebar(....)
with shiny.express.ui.page_navbar(sidebar=s):
    ....
```
It would be much better if we could pass in a sidebar object just as a *arg, and it would discover it and place it correctly.

cpsievert · 2023-12-13T15:23:25Z

@wch fwiw #893 addresses that sidebar issue for page_navbar(), meaning you can do something like this and it infers a page_navbar() context is relevant, and puts the sidebar in the keyword arg.

with ui.sidebar():
   ...

with ui.nav("Page 1"):
    "Page 1 content"

with ui.nav("Page 1"):
    "Page 2 content"

We still have that (sidebar kwarg) problem for navset_*(sidebar=) though, so it's maybe also worth having relevant navsets allow for a sidebar in their args

shiny/express/ui/__init__.py

shiny/express/_recall_context.py

shiny/express/layout.py

jcheng5 · 2023-12-21T17:51:47Z

I would lean context manager for card_header, if I had to choose one. Would it be crazy to support both, like the tags do? I know we can't do this for containers that have nontrivial logic relating to their children.

jcheng5 · 2023-12-21T18:28:54Z

shiny/express/_recall_context.py

+        if callable(getattr(res, "tagify", None)):
+            return res.tagify()  # pyright: ignore
+        if callable(getattr(res, "_repr_html_", None)):
+            return res._repr_html_()  # pyright: ignore


It would be nice if someday we could ask htmltools if an object is outputtable

* main: (24 commits) Use dynamic version of py-shiny for deploy tests (#970) Add underscores to hide some imports (#978) Add rsconnect json files(shinyapps.io tests) and folium tests (#928) Express' `value_box()` no longer includes named positional args (#966) Include `tooltip()` and `popover()` in express (#949) Remove extra call to run_express() Call `tagify()` early to intercept `AttributeErrors` (#941) Don't pass sidebar twice to navbar_page Update changelog Update changelog Switch from `requests` to `urllib` (#940) Bump version to 0.6.1.1 Fix docstring for page_opts Fix API doc sections for Express Smarter, lazier, and more complete page default/api for express (#893) Change `express.layout` to `express.ui` (#904) Remove `@output` from examples (#790) feat: Allow for `App` `server=` to take `input` only (#920) Add fixes for type stub generation (#828) Move quarto express docs to bottom ...

wch added 4 commits December 12, 2023 10:28

WIP convert layout to ui

5fa9a52

Add remaining components to shiny.express.ui

19b8f44

Install htmltools from github

fac3ca2

Update examples

d9361d2

wch force-pushed the express-layout-to-ui branch from d1eb2d8 to d9361d2 Compare December 13, 2023 01:31