Use dynamic version of py-shiny for deploy tests #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
reviewed
Jan 4, 2024
Co-authored-by: Winston Chang <winston@posit.co>
karangattu
commented
Jan 5, 2024
karangattu
commented
Jan 5, 2024
karangattu
commented
Jan 5, 2024
schloerke
approved these changes
Jan 8, 2024
schloerke
added a commit
that referenced
this pull request
Jan 8, 2024
* main: (24 commits) Use dynamic version of py-shiny for deploy tests (#970) Add underscores to hide some imports (#978) Add rsconnect json files(shinyapps.io tests) and folium tests (#928) Express' `value_box()` no longer includes named positional args (#966) Include `tooltip()` and `popover()` in express (#949) Remove extra call to run_express() Call `tagify()` early to intercept `AttributeErrors` (#941) Don't pass sidebar twice to navbar_page Update changelog Update changelog Switch from `requests` to `urllib` (#940) Bump version to 0.6.1.1 Fix docstring for page_opts Fix API doc sections for Express Smarter, lazier, and more complete page default/api for express (#893) Change `express.layout` to `express.ui` (#904) Remove `@output` from examples (#790) feat: Allow for `App` `server=` to take `input` only (#920) Add fixes for type stub generation (#828) Move quarto express docs to bottom ...
schloerke
added a commit
that referenced
this pull request
Jan 8, 2024
* main: Use dynamic version of py-shiny for deploy tests (#970)
schloerke
added a commit
that referenced
this pull request
Jan 9, 2024
* main: Use dynamic version of py-shiny for deploy tests (#970) Add underscores to hide some imports (#978) Add rsconnect json files(shinyapps.io tests) and folium tests (#928) Express' `value_box()` no longer includes named positional args (#966) Include `tooltip()` and `popover()` in express (#949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we used
git+https://github.com/posit-dev/py-shiny.gitin the requirements.txt file for the deploy tests,connectwould cache the version of py-shiny. Theconnectteam suggested to usehashinstead.This commit dynamically fetches the hash of py-shiny
mainand adds to each of therequirements.txtfor deploy tests.Deleted the older mentions of
py-shinyTested locally with one deploy test deploying to connect and it worked fine.