Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the fontspec error about \newfontfamily #236

Closed
wants to merge 1 commit into from
Closed

fix the fontspec error about \newfontfamily #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fontawesome.sty
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
\usepackage{fontspec}

% Define shortcut to load the Font Awesome font.
\newfontfamily{\FA}{FontAwesome}
\newfontfamily{\FA}{FontAwesome.otf}
Copy link

@thehamstermuffin thehamstermuffin Sep 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work, but I think this should be ttf to correspond to the font file

Suggested change
\newfontfamily{\FA}{FontAwesome.otf}
\newfontfamily{\FA}{FontAwesome.ttf}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't otf format have more features than ttf? Having that in mind, otf would be the best choice if we add the corresponding file

% Generic command displaying an icon by its name.
\newcommand*{\faicon}[1]{{
\FA\csname faicon@#1\endcsname
Expand Down