Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the equations in the paper #15

Closed
emjay73 opened this issue Apr 15, 2022 · 3 comments
Closed

Question about the equations in the paper #15

emjay73 opened this issue Apr 15, 2022 · 3 comments
Labels
question Further information is requested

Comments

@emjay73
Copy link

emjay73 commented Apr 15, 2022

Q1
image
Is it true that each element of n is divided by c ? not f?

Also, what is the meaning of p' value?
undistorted pixel?

Q2
image
In this equation, I'm not sure why $z_d$ is multiplied twice.

Q3
image
In this equation, why divide it by $r_{A,d} \cdot r_{A,d}$ instead of $||r_{A,d}||$ ?

Q4
image
In this equation, round L in the last term should be round r?

@emjay73 emjay73 changed the title Question about eq.5-8 Question about the equations in the paper Apr 15, 2022
@jeongyw12382 jeongyw12382 added the question Further information is requested label Apr 17, 2022
@jeongyw12382
Copy link
Collaborator

Thanks for your questions.
We'll double check your questions here and soon give you the reply.

@jeongyw12382
Copy link
Collaborator

An update for this issue.

  1. We have normalized the coordinate of each pixel to [-1, 1] when applying radial distortions. Using f instead of c could also enhance the camera model. However, we expect changing the radial parameters could somewhat show similar behaviors. This setups were fine for our experiments. (+p' is the pixel coordinate after distortions have been applied)
    2, 3, 4. You are right. We will update the arXiv preprint soon. Fortunately, the pointed parts do not cause errors in our code or performance. Thanks for your suggestion.

@emjay73
Copy link
Author

emjay73 commented Apr 25, 2022

About Q1.
I thought the purpose of the eq5 is to convert pixel coordinates to normalized coordinate(z=1) as other distortion model does, but what you actually intended was to make pixel coordinates range from -1 to 1 right?
And if p' is distorted pixel coordinates, then the ray direction in eq 8 is a distorted ray direction?
I expected p' to be undistorted pixel coordinates so it's a bit confusing.

About Q2,3,4
Thank you for your confirmation. You cleared things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants