Skip to content

Commit

Permalink
Make build with wagyu the default when protobuf is also enabled
Browse files Browse the repository at this point in the history
Closes #406

git-svn-id: http://svn.osgeo.org/postgis/trunk@17451 b70326c6-7e19-0410-871a-916f4a2858ee
  • Loading branch information
robe2 committed Jun 1, 2019
1 parent 7f144d6 commit 4441d38
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 26 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ env:
- tag=pg11-geos37-gdal24-proj52 mode=coverage
- tag=pg11-geos37-gdal24-proj52 mode=usan_gcc
- tag=pg11-geos37-gdal24-proj52 mode=usan_clang
- tag=pg11-geos37-gdal24-proj52 mode=wagyu
- tag=pg11-geos37-gdal24-proj52 mode=nowagyu
- tag=pg11-geos37-gdal24-proj52 mode=tests
- tag=pg10-geos36-gdal23-proj49 mode=tests
- tag=pg96-geos36-gdal22-proj49 mode=tests
Expand Down
19 changes: 18 additions & 1 deletion NEWS
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
PostGIS 3.0.0alpha2
2019/XX/XX

For full changes and enhancements, refer to PostGIS 3.0.0 section.
This version requires PostgreSQL 9.5+-12 and GEOS >= 3.6+
Additional features enabled if you are running Proj6+ and PostgreSQL 12

* Major highlights *
- #4404, Fix selectivity issue with support functions (Paul Ramsey)
- #4311, Make wagyu the default option to validate polygons.
This option requires a C++11 compiler and will use CXXFLAGS (not CFLAGS).
Add `--without-wagyu` to disable this option and keep the behaviour
from 2.5 (Raúl Marín)


PostGIS 3.0.0alpha1
2019/05/26
For full changes and enhancements, refer to PostGIS 3.0.0 section.
Expand Down Expand Up @@ -59,7 +74,9 @@ PostGIS 3.0.0
within, equals (Esteban Zimányi and Arthur Lesuisse from Université
Libre de Bruxelles (ULB), Darafei Praliaskouski)
- #4171, ST_3DLineInterpolatePoint (Julien Cabieces, Vincent Mora)
- #4311, Introduce `--with-wagyu` as an option for MVT polygons (Raúl Marín)
- #4311, Introduce WAGYU to validate MVT polygons. This option requires a C++11
compiler and will use CXXFLAGS (not CFLAGS). Add `--without-wagyu`
to disable this option and keep the behaviour from 2.5 (Raúl Marín)
- #1833, ST_AsGeoJSON(row) generates full GeoJSON Features (Joe Conway)
- #3687, Casts json(geometry) and jsonb(geometry) for implicit GeoJSON
generation (Paul Ramsey)
Expand Down
18 changes: 0 additions & 18 deletions ci/travis/run_wagyu.sh

This file was deleted.

6 changes: 3 additions & 3 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -1472,9 +1472,9 @@ HAVE_WAGYU=no
if test "x$HAVE_PROTOBUF" = "xyes"; then
AC_ARG_WITH(
[wagyu],
AC_HELP_STRING([--with-wagyu], [Use the wagyu library]),
[HAVE_WAGYU=yes],
[HAVE_WAGYU=no])
AC_HELP_STRING([--without-wagyu], [Don't use the wagyu library]),
[HAVE_WAGYU=no],
[HAVE_WAGYU=yes])

if test "x$HAVE_WAGYU" = "xyes"; then
AC_MSG_RESULT([WAGYU: Wagyu usage requested])
Expand Down
6 changes: 3 additions & 3 deletions doc/installation.xml
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ psql -d yourdatabase -f sfcgal_comments.sql
To enable ST_AsMVT protobuf-c library (for usage) and the protoc-c compiler (for building) are required.
Also, pkg-config is required to verify the correct minimum version of protobuf-c.
See <ulink url="https://github.com/protobuf-c/protobuf-c">protobuf-c</ulink>.
To use Wagyu to validate MVT polygons faster, a c++11 compiler is required. It requires <varname>--with-wagyu</varname> to be passed during configure; and it will use CXXFLAGS and the same compiler as the PostgreSQL installation.
By default, Postgis will use Wagyu to validate MVT polygons faster which requires a c++11 compiler. It will use CXXFLAGS and the same compiler as the PostgreSQL installation. To disable this and use GEOS instead use the <varname>--without-wagyu</varname> during the configure step.
</para>
</listitem>

Expand Down Expand Up @@ -599,10 +599,10 @@ tar -xvzf postgis-&last_release_version;.tar.gz</programlisting>
</listitem>
</varlistentry>
<varlistentry>
<term><command>--with-wagyu</command></term>
<term><command>--without-wagyu</command></term>
<listitem>
<para>
When building with MVT support, by default Postgis will use GEOS to clip and validate MVT polygons. You can use <ulink url="https://github.com/mapbox/wagyu/">Wagyu</ulink> instead which is faster and guaranteed to produce correct values for this specific case.
When building with MVT support, Postgis will use <ulink url="https://github.com/mapbox/wagyu/">Wagyu</ulink> to clip and validate MVT polygons. Wagyu is the fastest alternative and guarantees producing correct values for this specific case, but it requires a C++-11 compiler. With this optional argument you can disable using this library; GEOS will be used instead.
</para>
</listitem>
</varlistentry>
Expand Down

0 comments on commit 4441d38

Please sign in to comment.