-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline handler and basic syntax validator #55
Conversation
9c64875
to
2ab6c87
Compare
ba44c5c
to
229c7ea
Compare
This closes postgres-plr#9
This allows to have SQL statements like do language plr $$ pg.throwlog("Hello, world!) $$;
Try to parse R function body. No other checks done.
This partially reverts squashed c42eb9c
I think it is getting too long. Let me know whether it would be better to split this one. |
@mlt if you think it's too long then as a reviewer it's gonna be too long. Please split it up. Thanks! |
6fe29e2
to
b5a610b
Compare
Make little to no difference between returning a RECORD or having one or a few OUT arguments
I think it is manageable now. I am done editing this one…more PRs on the way. |
seems appveyor allow failures doesn't work quite right. Since 9.3 is now EOL, I propose we just remove the test for it. |
Seems I was hasty with that. Either way 9.3 is no longer supported we could remove tests for it. |
It feel like it was some sort of AppVeyor glitch. I will submit another PR with changelog and 9.3 cut out. We'll see how that build goes. |
Shall we follow https://github.com/olivierlacan/keep-a-changelog/blob/master/CHANGELOG.md while at it? It seems like GitHub interprets it and can show links to commits in between versions. I don't feel like heavily revising existing log. So maybe just from now on? |
On Thu, 23 May 2019 at 14:20, Mikhail Titov ***@***.***> wrote:
Shall we follow
https://github.com/olivierlacan/keep-a-changelog/blob/master/CHANGELOG.md
while at it? It seems like GitHub interprets it and can show links to
commits in between versions. I don't feel like heavily revising existing
log. So maybe just from now on?
Sure, works for me.
… |
This PR introduces few new features:
DO
statements)Misc. bug fixes: