Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline handler and basic syntax validator #55

Merged
merged 13 commits into from
May 23, 2019
Merged

Conversation

mlt
Copy link
Collaborator

@mlt mlt commented Apr 10, 2019

This PR introduces few new features:

  • Inline language handler (DO statements)
  • Basic function body syntax checker by trying to parse it
  • Support for OUT arguments

Misc. bug fixes:

  • Don't export unnecessary functions on Windows
  • Incorrect fnumrows (0) could be reported for window functions called with a stable expression passed as the last argument
  • Fix casting REALSXP arrays into numeric[]

appveyor.yml Outdated Show resolved Hide resolved
@mlt mlt force-pushed the inline branch 5 times, most recently from ba44c5c to 229c7ea Compare May 1, 2019 04:43
mlt added 6 commits May 10, 2019 00:29
This allows to have SQL statements like

do language plr $$
  pg.throwlog("Hello, world!)
$$;
Try to parse R function body. No other checks done.
@mlt
Copy link
Collaborator Author

mlt commented May 10, 2019

I think it is getting too long. Let me know whether it would be better to split this one.

@davecramer
Copy link
Collaborator

@mlt if you think it's too long then as a reviewer it's gonna be too long. Please split it up.

Thanks!
Dave

@mlt mlt force-pushed the inline branch 4 times, most recently from 6fe29e2 to b5a610b Compare May 11, 2019 04:01
mlt added 2 commits May 14, 2019 18:11
Make little to no difference between returning a RECORD
or having one or a few OUT arguments
@mlt
Copy link
Collaborator Author

mlt commented May 14, 2019

I think it is manageable now. I am done editing this one…more PRs on the way.

@davecramer davecramer merged commit 299794e into postgres-plr:master May 23, 2019
@davecramer
Copy link
Collaborator

seems appveyor allow failures doesn't work quite right. Since 9.3 is now EOL, I propose we just remove the test for it.

@davecramer
Copy link
Collaborator

Seems I was hasty with that. Either way 9.3 is no longer supported we could remove tests for it.

@mlt
Copy link
Collaborator Author

mlt commented May 23, 2019

It feel like it was some sort of AppVeyor glitch. I will submit another PR with changelog and 9.3 cut out. We'll see how that build goes.

@mlt
Copy link
Collaborator Author

mlt commented May 23, 2019

Shall we follow https://github.com/olivierlacan/keep-a-changelog/blob/master/CHANGELOG.md while at it? It seems like GitHub interprets it and can show links to commits in between versions. I don't feel like heavily revising existing log. So maybe just from now on?

@davecramer
Copy link
Collaborator

davecramer commented May 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants