Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote control commands design #34

Closed
pierrickrouxel opened this issue Feb 8, 2017 · 1 comment
Closed

Remote control commands design #34

pierrickrouxel opened this issue Feb 8, 2017 · 1 comment

Comments

@pierrickrouxel
Copy link
Contributor

Is it voluntary to use topmenu rather than top_menu to name the remote control command? It does not match the design of set_position.

This is not really important but as it is a fresh project, there is still time to change :)
@postlund
Copy link
Owner

postlund commented Feb 9, 2017

It's just a straight translation from the API as the underlaying function (sent to the device) is called topmenu. So that's the reason :) But you are right, it might be good to change to be consistent. Feel free to send a PR! :)

@pierrickrouxel pierrickrouxel mentioned this issue Feb 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pierrickrouxel @postlund