Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional self-telemetry about ES retries #361

Open
blakebarnett opened this issue Dec 6, 2017 · 3 comments
Open

Add additional self-telemetry about ES retries #361

blakebarnett opened this issue Dec 6, 2017 · 3 comments

Comments

@blakebarnett
Copy link
Contributor

For more visibility into how many retries it's taking to flush cernan's log lines buffer. I suppose a counter for any failures would be helpful here too if there's not already one.

@blt
Copy link
Collaborator

blt commented Feb 21, 2018

I believe this can be inferred -- as of this writing -- by summing over all the elastic API errors. We could also add a bit of telemetry for just any failure. @blakebarnett got a preference?

@blakebarnett
Copy link
Contributor Author

A general error count would be good, but having a breakdown by type/source/sink etc. would be even better :)

@blt
Copy link
Collaborator

blt commented Feb 21, 2018

@blakebarnett fully agreed. Main trick now is cernan's internal telemetry is mostly atomic counters. It's hard to get meta-data associated. That said, the sinks/sources do have counters for these things but they're just bare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants