Skip to content

Commit

Permalink
needed headers if we are not using straight up goliath
Browse files Browse the repository at this point in the history
  • Loading branch information
@dj2
dj2 committed Feb 26, 2011
1 parent a27692b commit 1fe5114
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/goliath/request.rb
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
require 'eventmachine'
require 'goliath/constants'
require 'async_rack'
require 'stringio'

module Goliath
# Goliath::Request is responsible for processing a request and returning
# the result back to the client.
Expand Down

7 comments on commit 1fe5114

@igrigorik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean "not using straight up goliath"?

@dj2
Copy link
Contributor Author

@dj2 dj2 commented on 1fe5114 Feb 26, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom_server

@igrigorik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But even in that case, why wouldn't you require 'goliath'? Think I'm missing a step.

@dj2
Copy link
Contributor Author

@dj2 dj2 commented on 1fe5114 Feb 26, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because that pulls in application which is what we're trying to avoid as we don't want the autoloader

@igrigorik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case, why not delegate adding all the requires to the person creating custom_server? After all.. it is custom :-)

@dj2
Copy link
Contributor Author

@dj2 dj2 commented on 1fe5114 Feb 26, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because that's annoying as hell. They pull in what they need from Goliath but goliath should be set up to pull in what it needs.

@igrigorik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, fair enough.

Please sign in to comment.