Don't allow publishing to an exchange that is not open. #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2015 13:22
Also, ack errors all unacked messages on connection errors in addition to channel errors. When the connection goes down, it will only be "detected" during the next attempt to interact with it. If this happens to be a basicPublish, then it would fire a callback if not for the fix.
| @@ -25,7 +25,7 @@ conn.once('ready', function () { | |||
| later(function(){ | |||
| // This will emit a NOT_FOUND error b/c we're no longer bound to the exchange | |||
| var thrown = false; | |||
| conn.addListener('error', function(e){ | |||
| exchange.addListener('error', function(e){ | |||
There was a problem hiding this comment.
Need some help on this one: the error event is not triggered on connection for some reason. That is not the case if I don't add error handlers on channelOpenOk.
v-yarotsky
force-pushed
the
vy-fix-confirm-sequencing-after-recovery
branch
from
5755654
to
c153988
Compare
|
Might help with #373. |
postwait
added a commit
that referenced
this pull request
Aug 8, 2015
…r-recovery Don't allow publishing to an exchange that is not open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents nasty issues like callbacks that are not fired when publisher confirmations are turned on, caused by broker-client acknowledgement sequencing mismatch.
Whenever a connection error occurs, if publisher confirmations are enabled, all currently unacked messages emit 'ack error' instead of not calling the callback altogether.
There also are two tests that don't pass for me on master, as well as on this branch.