Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with vue 2.6.x #18

Closed
ibes opened this issue Feb 8, 2019 · 11 comments
Closed

Compatibility with vue 2.6.x #18

ibes opened this issue Feb 8, 2019 · 11 comments

Comments

@ibes
Copy link

ibes commented Feb 8, 2019

Hi there,

I tried to follow the tutorial of vue-dose to slots in new vue 2.6.x format.
I am very new to slots so likely I get things wrong - but can it be that vue-promised is not yet compatible with vue 2.6.x slots?

Link to the tutorial:
https://vuedose.tips/tips/4

@posva
Copy link
Owner

posva commented Feb 8, 2019

It is compatible but I haven't got the time to adapt the README yet, I will do when I have time.

You can use v-slot:combined="{ isPending, data }" directly on Promised now but for the other slots, you must use a template

@posva posva closed this as completed Feb 8, 2019
@ibes
Copy link
Author

ibes commented Feb 8, 2019

then the problem lays on my side. Good to know.

@posva
Copy link
Owner

posva commented Feb 9, 2019

I updated the examples with the new syntax :)

@ibes
Copy link
Author

ibes commented Feb 10, 2019

Thank you.

The example without "combined" is still not using the new v-slot, right?
Is that not possible?

Sorry - I really have to little knowledge about it - I just try to understand how it is done and try to find out, if the vuedose.tips solution should be usable or if there is a error in what the author wrote.
So for me right now it is to try to understand patterns.

@Trif4
Copy link

Trif4 commented Feb 11, 2019

I can't get it to work with the new syntax either. <template slot="pending"> works, but <template #pending> doesn't.

@ibes
Copy link
Author

ibes commented Feb 11, 2019

As far as I get it slot has just similarities but is not the same as v-slot (<- the new thing)
and #pending is a shothand for v-slot=pending

I was not able to get v-promised to work with the new v-slot syntax.

I already asked the author of vuedose if he can help to clarify things.

Maybe his code example was just a "would look like" and not a "this actually work"

@Trif4
Copy link

Trif4 commented Feb 11, 2019

This is due to this issue which is resolved in Vue 2.6.4.

@ibes
Copy link
Author

ibes commented Feb 11, 2019

Could you please share a working example of using vue-promised with the 2.6.x syntax that works for you @Trif4 ?

@ibes
Copy link
Author

ibes commented Feb 11, 2019

@posva - doesn't yet feel solved/closed.
But likely is not something that needs to be fixed in vue-promised put feels like there is some documentation that could be helpful for vue 2.6.x and newer

@posva
Copy link
Owner

posva commented Feb 11, 2019

The syntax is working correctly, the readme is up to date, the demos are using the new syntax and I checked vuedose and the example is good too...
The reverse proxy deployed on now is failing but maybe it is because they updated their platform. I will have to deploy another reverse proxy or an api to retrieve the xkcd comics

@ibes
Copy link
Author

ibes commented Feb 11, 2019

thank you for verifying :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants