-
Notifications
You must be signed in to change notification settings - Fork 78
Route file ignored when both file and directory present. #104
Comments
@henrymazza yes I agree with you. ember-crumbly should not render The current proposed solution: |
I was playing with this yesterday and it actually gets a bit complicated / messy if you have nested routes under an
Wondering if anybody else is using similar routing structure or if I'm covering an extreme edge case here. |
@henrymazza @andrewfan @sergproua @mrkirchner @knownasilya
|
Seems to work as you described but i am not sure i agree with the proposed solution:
Shouldn't bar also fallback to bar crumb if index doesn't exist? Right now even if i define a breadcrumb at the bar route it is not used when the last crumb. I have to add index route with breadcrumb for almost every route now. breadcrumb order i believe should always be
|
Index probably exists (ember generates it), that's why it's not falling back to |
Crumbly doesn’t honor Ember convention:
authors/Index.js
route isn’t parent ofauthors/posts.js
, it’s actually the default route. Loading/authors/1/posts
will not load index model, so can’t compute properties to make a “Jack > Posts” type of crumbs. User gonna see “Authors > Posts” then navigate away and back again to see “Jack > Posts” and get confused.There’s an
authors.js
route adjacent to authors directory which will load model and compute its properties but it gets ignored. Most people use index, ok, but no excuse to ignore the right file.PS: It may be related to #99 (but with less commas)
The text was updated successfully, but these errors were encountered: