Skip to content
This repository has been archived by the owner on Nov 9, 2021. It is now read-only.

Using resetNamespace breaks crumbs #58

Closed
ivanvanderbyl opened this issue Jan 7, 2016 · 1 comment
Closed

Using resetNamespace breaks crumbs #58

ivanvanderbyl opened this issue Jan 7, 2016 · 1 comment

Comments

@ivanvanderbyl
Copy link
Contributor

One of the great uses for crumbly is solving the navigation headache of returning to a previous route in heavily nested routes. However, Ember provides resetNamespace to prevent your actual code requiring heavy nesting. I'm not sure if others find this to be an issue, but when resetting the namespace, Crumbly's first route returns to the reset point.

This is problematic because it no longer reflects how our user navigated here. This could possibly be solved by #19, but I also think we could solve it much more easily by not using currentRouteName, and perhaps using currentURL or something similar. I'm not sure if this offers the same route lookup mechanism or not. This might be a breaking change for some users.

Thoughts?

@ivanvanderbyl
Copy link
Contributor Author

Here's a PR to fix this: #64

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant