Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ouput in JSON #6

Closed
pouriyajamshidi opened this issue May 8, 2022 · 4 comments
Closed

Ouput in JSON #6

pouriyajamshidi opened this issue May 8, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@pouriyajamshidi
Copy link
Owner

Summary

Some monitoring systems could use the output of tcping to be in JSON for easier parsing and processing.

Having a flag to change the output type would be nice. However, there are a lot to be changed since the current output is colorized.
@pouriyajamshidi pouriyajamshidi added the enhancement New feature or request label May 8, 2022
@pouriyajamshidi pouriyajamshidi added good first issue Good for newcomers and removed good first issue Good for newcomers labels May 29, 2022
@icemint0828
Copy link
Contributor

icemint0828 commented Jun 18, 2022 •
edited
Loading

@pouriyajamshidi

I think Ouput in JSON can be divided into three processes.

  • To be able to output both plane text and json text.
  • To be able to choose between plane text and json text output with a flag(Something similar to this has been done in the past).
  • Thinking about the contents of json text.

I'll take the first two.

@icemint0828 icemint0828 mentioned this issue Jun 18, 2022
Merged
@pouriyajamshidi
Copy link
Owner Author

@icemint0828 very clean and nice job.

the third point you mentioned, should be the exact same information as the planePrinter.

@icemint0828
Copy link
Contributor

@pouriyajamshidi

the third point you mentioned, should be the exact same information as the planePrinter.

If you're not particular, this is fine.
Sorry but please work on it.

@pouriyajamshidi
Copy link
Owner Author

Partially addressed in 8296319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pouriyajamshidi @icemint0828